-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate into React Router 7 #33
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
84afcbf
to
0e20f61
Compare
ad9dc20
to
fb49b99
Compare
"orval": "orval", | ||
"test": "vitest", | ||
"test:run": "vitest run", | ||
"check": "yarn build && yarn lint && yarn format:ci && yarn typecheck && yarn test:run" | ||
"check": "pnpm typecheck && pnpm build && pnpm lint && pnpm format:ci && pnpm test:run" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この PR に関係ないが pnpm 移行 PR でやり忘れていたので
|
||
const ABORT_DELAY = 5_000; | ||
import { handleRequest as vercelHandleRequest } from "@vercel/react-router/entry.server"; | ||
import type { AppLoadContext, EntryContext } from "react-router"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現状の実装とほぼ同じことを Vercel のプリセットがやっていたので実装を差し替え
https://github.com/vercel/vercel/blob/main/packages/react-router/entry.server.ts
57135a5
to
8d66f8d
Compare
8d66f8d
to
60052b0
Compare
React Router 7 に上げる理由: React 19 を使用したいため
React 19 を使用したい理由: #17 (comment)
v3_routeConfig
: ac1d583codemod remix/2/react-router/upgrade
: e590640