Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate into React Router 7 #33

Merged
merged 12 commits into from
Mar 9, 2025
Merged

feat: migrate into React Router 7 #33

merged 12 commits into from
Mar 9, 2025

Conversation

sushichan044
Copy link
Collaborator

@sushichan044 sushichan044 commented Mar 4, 2025

React Router 7 に上げる理由: React 19 を使用したいため
React 19 を使用したい理由: #17 (comment)


@sushichan044 sushichan044 self-assigned this Mar 4, 2025
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
birdxplorer-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:07am

"orval": "orval",
"test": "vitest",
"test:run": "vitest run",
"check": "yarn build && yarn lint && yarn format:ci && yarn typecheck && yarn test:run"
"check": "pnpm typecheck && pnpm build && pnpm lint && pnpm format:ci && pnpm test:run"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この PR に関係ないが pnpm 移行 PR でやり忘れていたので


const ABORT_DELAY = 5_000;
import { handleRequest as vercelHandleRequest } from "@vercel/react-router/entry.server";
import type { AppLoadContext, EntryContext } from "react-router";
Copy link
Collaborator Author

@sushichan044 sushichan044 Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現状の実装とほぼ同じことを Vercel のプリセットがやっていたので実装を差し替え
https://github.com/vercel/vercel/blob/main/packages/react-router/entry.server.ts

@sushichan044 sushichan044 force-pushed the feat/react-router-7 branch from 8d66f8d to 60052b0 Compare March 7, 2025 08:06
@yu23ki14 yu23ki14 merged commit 39bca07 into main Mar 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants